Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit passing an address via payment source parameters #3713

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

kennyadsl
Copy link
Member

Description

This is a complementary PR for the last security fix.
Bill address can be passed as params when submitting a new source.

No hurry merging this, it's on master and not tied to any released version yet.

This is a complementary commit for the last security fix.
Bill address can be passed as params when submitting a new source.

This also resumes a spec that was removed a while ago and apparently
it was the only one testing this feature.
@kennyadsl kennyadsl self-assigned this Jul 16, 2020
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl thanks! 👍

@kennyadsl kennyadsl merged commit 4422628 into solidusio:master Aug 26, 2020
@kennyadsl kennyadsl deleted the permit_address-source branch August 26, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants